Slotted enumeration faster #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes to enumeration over
SlottedArray:EnumerateAllthat enumerates now with a bit less overhead (code size reduction and some inlines)EnumerateNibblethat uses the new encoding of length to to leverage the filtering and returns data without having their keys unprepared if not needed. It's not 16 faster, but gives ~3x performance boost for scans.Benchmarks
For
EnumerateAllthe existing one is used. ForEnumerateNibblenew benchmarks were added as previously it was filtering over the materialized key which was not different fromEnumerateAll.Before
After